[libcxx-commits] [PATCH] D149543: [libc++][format] Fixes vector<bool> requirements.

[Hans Wennborg via Phabricator via libcxx-commits]

hans added a comment.

In Chromium we noticed that this almost doubled the preprocessed size of `<vector>`, from ca 1.6 MB to 3.2 MB. Since it's a widely included header, that results in ca 8 GB (2.5%) of extra code to compile during a full build.

I realize this change is based on a requirement in the standard, but it seems unfortunate that the cost of the format library is spilling over to vector like this. If there's anything that could be done to reduce the impact here, that would be very valuable to us and presumably other libc++ users too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149543/new/

https://reviews.llvm.org/D149543