[libcxx-commits] [PATCH] D153816: [libc++][hardening][NFC] Introduce `_LIBCPP_ASSERT_UNCATEGORIZED`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ green CI (seems like you need to format a couple of headers).

In D153816#4452854 <https://reviews.llvm.org/D153816#4452854>, @var-const wrote:

> [...]
>
> For the tests, my reasoning was that they are testing the assertions machinery and thus should use the fundamental assertion mechanism directly. Let me know what you think!

Ok, that sounds great!

In D153816#4453166 <https://reviews.llvm.org/D153816#4453166>, @Mordante wrote:

> Is there already a plan which categories you want to make?

And users would enable `_LIBCPP_ENABLE_HARDENED_MODE` or `_LIBCPP_ENABLE_DEBUG_MODE` (names not final), but wouldn't actually control the exact assertion categories. Each of `_LIBCPP_ENABLE_HARDENED_MODE` and `_LIBCPP_ENABLE_DEBUG_MODE` would basically be a cherry-pick of various categories of assertions. That's the current plan at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153816/new/

https://reviews.llvm.org/D153816