[libcxx-commits] [PATCH] D151637: DRAFT: hardening "interface"

Tue Jun 27 10:49:47 PDT 2023

var-const added inline comments.

================
Comment at: libcxx/include/__config:202-204
+// Enables all the checks that break the ABI.
+//
+// #define _LIBCPP_ENABLE_HARDENED_MODE_ABI_BREAK 1
----------------
ldionne wrote:
> I would suggest not introducing this macro, at least not for now. Instead, I would rename `_LIBCPP_ASSERTIONS_ENABLE_HARDENING_BOUNDED_ITERATORS` to `_LIBCPP_ABI_BOUNDED_ITERATORS`, a normal ABI macro like we have others and I would simply not define it in any configuration by default. In fact, this could be done in a separate patch to simplify this one quite a bit.
> 
> Actually if you do that in a separate patch, `_LIBCPP_ABI_BOUNDED_ITERATORS` could take over `_LIBCPP_DEBUG_ITERATOR_BOUNDS_CHECKING`.
Patch for introducing `_LIBCPP_ABI_BOUNDED_ITERATORS`: https://reviews.llvm.org/D153895

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151637/new/

https://reviews.llvm.org/D151637