[libcxx-commits] [PATCH] D150802: [libc++][format] Removes the experimental status.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D150802#4451486 <https://reviews.llvm.org/D150802#4451486>, @hans wrote:

> Sharing in case anyone else runs into the same problem: This caused Chromium builds to fail on Windows due to not linking against compiler-rt's builtins library. It turns out this patch caused us to compile some code doing 128-bit arithmetic and calling the `__udivti3` runtime function. We worked around it by defining `_LIBCPP_HAS_NO_INT128` until we can make the builtins library part of all our builds.

Interesting that this caused it. I expect the real cause is `std::to_char` for 128-bit values, there divisions are used. Does that mean the flag in `__config` is not set correctly? It was recently updated in D134912 <https://reviews.llvm.org/D134912>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150802/new/

https://reviews.llvm.org/D150802