[libcxx-commits] [PATCH] D153672: [libc++] Remove the legacy debug mode.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Based on the information on discourse no objection against removal in LLVM-17.
LGTM modulo some nits, leaving final approval to @ldionne.



================
Comment at: libcxx/CMakeLists.txt:65
 option(LIBCXX_INCLUDE_TESTS "Build the libc++ tests." ${LLVM_INCLUDE_TESTS})
-option(LIBCXX_ENABLE_DEBUG_MODE
-  "Whether to build libc++ with the debug mode enabled.
----------------
This flag is used in `docs/DesignDocs/DebugMode.rst`, please update that document.


================
Comment at: libcxx/docs/ReleaseNotes.rst:77
+  the `Discourse post
+  <https://discourse.llvm.org/t/rfc-removing-the-legacy-debug-mode-from-libc/71026>`_
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153672/new/

https://reviews.llvm.org/D153672