[libcxx-commits] [PATCH] D153816: [libc++][hardening][NFC] Introduce `_LIBCPP_ASSERT_UNCATEGORIZED`.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added a comment.

In D153816#4452334 <https://reviews.llvm.org/D153816#4452334>, @ldionne wrote:

> Are there still instances of raw `_LIBCPP_ASSERT`?
>
> This basically LGTM but I'd like to know the answer to this before we merge (also, CI).

Yes, there are some:

1. In `debug.cpp` -- I haven't touched those, hoping that makes them go away and to avoid a merge conflict (although it would be trivial to solve, to be fair).
2. In `test/support/test.support/test_check_assertion.pass.cpp`.
3. In tests under `test/libcxx/assertions/`.

For the tests, my reasoning was that they are testing the assertions machinery and thus should use the fundamental assertion mechanism directly. Let me know what you think!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153816/new/

https://reviews.llvm.org/D153816