[libcxx-commits] [PATCH] D153211: [libc++][Modules] Make module exports consistent with header includes

[Ian Anderson via Phabricator via libcxx-commits]

iana added inline comments.


================
Comment at: libcxx/include/cwchar:113
 #include <cwctype>
+#include <stdio.h>
 
----------------
Mordante wrote:
> Is this really needed, it looks weird; C headers should be independent.
I think it was transitively included, but cwchar explicitly exports the module, so it needs to include the header.


================
Comment at: libcxx/include/string_view:230
 #include <__type_traits/type_identity.h>
+#include <initializer_list>
 #include <iosfwd>
----------------
Mordante wrote:
> The header does not use `initializer_list` why is it needed?
string_view's module explicitly exports it, and this one I'm pretty sure wasn't being transitively included. So this export would definitely break without the include being added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153211/new/

https://reviews.llvm.org/D153211