[libcxx-commits] [PATCH] D151267: mdspan: implement layout_right

[Christian Trott via Phabricator via libcxx-commits]

crtrott marked 8 inline comments as done.
crtrott added inline comments.


================
Comment at: libcxx/include/__mdspan/layout_right_mapping.h:71
+
+  static_assert((extents_type::rank_dynamic() > 0) || __required_span_size_is_representable(extents_type()),
+                "layout_right::mapping product of static extents must be representable as index_type.");
----------------
Mordante wrote:
> Can this be moved to the other `static_assert` in this class?
I think it would make it less readable. We need to test the first static_assert before we use the template parameter for dependent types, and the second static_assert impl requires those dependent types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151267/new/

https://reviews.llvm.org/D151267