[libcxx-commits] [PATCH] D144362: [libcxx] <experimental/simd> Add ABI tags, class template simd/simd_mask implementations. Add related simd traits and tests.

Sun Jun 25 12:45:56 PDT 2023

philnik added a comment.

In D144362#4446950 <https://reviews.llvm.org/D144362#4446950>, @Joy12138 wrote:

> The solution looks great. It works well overall, but there's one aspect I believe could be improved. Since a basic `simd` need `type` and `simdabi` 2 factors, `type` will usually be used in most of the test functors. I intend to pass the `type` to `F`.
>
> For clarity, I've made a comparison of the codes which you can review at the following link: https://www.diffchecker.com/2ja2Qq7t/

Sounds good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144362/new/

https://reviews.llvm.org/D144362