[libcxx-commits] [PATCH] D153427: [libc++] Add noexcept clauses to swap per P0408R7 (Efficient Access to basic_stringbuf's Buffer)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.assign/member_swap_noexcept.pass.cpp:92
+    std::basic_stringbuf<CharT, std::char_traits<CharT>, test_alloc_propagate_on_container_swap_not_empty<CharT>> buf;
+    static_assert(noexcept(buf.swap(buf1)));
+  }
----------------
pfusik wrote:
> Mordante wrote:
> > Can you add some test where `noexcept(buf.swap(buf1)) == false`.
> See five lines up.
Ah sorry I overlooked that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153427/new/

https://reviews.llvm.org/D153427