[libcxx-commits] [PATCH] D153405: [libc++] Add get_allocator and some constructor overloads of P0408R7 (Efficient Access to basic_stringbuf's Buffer)

[Piotr Fusik via Phabricator via libcxx-commits]

pfusik added a comment.

In D153405#4446388 <https://reviews.llvm.org/D153405#4446388>, @Mordante wrote:

> Sorry, but would it be possible to to a patch per class instead, starting with stringbuf? That way I can keep track that all classes are done. The subtile differences in all overloads make it really annoying the review for correctness.

Would you like **all ** the changes in `stringbuf` in one patch? That's quite a lot.
The remaining three classes are just simple wrappers over `stringbuf`.
I thought it would be easier to split into features.

Also, I expect that users don't typically `stringbuf` directly, so having them exposed in `*stringstream` is what they care. That's how we proceeded with the already merged `view()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153405/new/

https://reviews.llvm.org/D153405