[libcxx-commits] [PATCH] D144362: [libcxx] <experimental/simd> Add ABI tags, class template simd/simd_mask implementations. Add related simd traits and tests.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:22
+
+template <class F, std::size_t _Np, class _Tp, class SimdAbi, class... SimdAbis>
+void test_simd_abi();
----------------
These shouldn't be _Uglified, since they are part of the test code.


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:32
+void test_fixed_size_deduce_t(std::integer_sequence<std::size_t, _Np...>) {
+  (test_simd_abi<F, _Np + 1, _Tp, ex::simd_abi::fixed_size<_Np + 1>, ex::simd_abi::deduce_t<_Tp, _Np + 1>>(), ...);
+}
----------------
This makes this part a bit more complex, but the recursion inside the tests isn't there anymore, making them quite a bit simpler.


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:35
+
+template <class F, class _Tp>
+void test_all_simd_abi() {
----------------
It doesn't look like the F argument is ever used. Why did you add it?


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:39-41
+  constexpr static auto integer_seq_from_make_integer = std::make_integer_sequence<size_t, max_simd_size - 1>();
+
+  test_fixed_size_deduce_t<F, _Tp>(integer_seq_from_make_integer);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144362/new/

https://reviews.llvm.org/D144362