[libcxx-commits] [PATCH] D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, but please make sure the CI passes in C++20 before committing.



================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_iterator/directory_iterator.members/equal.pass.cpp:9
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
+
----------------
Please update the other tests too.


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_iterator/directory_iterator.members/equal.pass.cpp:29
+
+  {
+    fs::directory_iterator i;
----------------
In this case I would omit the extra scope, but I don't strongly object either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153299/new/

https://reviews.llvm.org/D153299