[libcxx-commits] [PATCH] D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel
Hristo Hristov via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jun 22 14:05:36 PDT 2023
H-G-Hristov added a comment.
@Mordante Thank you for the review!
================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_iterator/directory_iterator.members/equal.pass.cpp:28
+ fs::directory_iterator i;
+ assert(testEquality(i, std::default_sentinel, true));
+ }
----------------
Mordante wrote:
> Please test the following properties too
> - returns a `bool` using `AssertEqualityReturnBool`
> - `noexcept` using `AssertEqualityAreNoexcept`
Thank you for the tip!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153299/new/
https://reviews.llvm.org/D153299
More information about the libcxx-commits
mailing list