[libcxx-commits] [PATCH] D153209: Revert "[libc++][PSTL] Add missing includes to PSTL headers"

[Ian Anderson via Phabricator via libcxx-commits]

iana added a comment.

In D153209#4438890 <https://reviews.llvm.org/D153209#4438890>, @ldionne wrote:

> I don't understand this patch. We follow include-what-you-use in libc++. These headers are using the entities declared by the includes you're removing, I think we should keep them. In other words, those files should have been including these headers since they were written, regardless of whether it helps with disentangling the Clang modules story or not. Do I misunderstand something? If not, I think we can abandon this.

I guess it doesn't hurt to have these extra includes, but they mask the missing module exports which are important to have. Without the exports, many unit tests have compiler errors, and even linker errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153209/new/

https://reviews.llvm.org/D153209