[libcxx-commits] [libcxx] b356928 - [libc++] Fix the check-format job
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jun 21 14:59:53 PDT 2023
Author: Louis Dionne
Date: 2023-06-21T17:59:32-04:00
New Revision: b3569280586aec3e4d5ea61634f0a841e5827244
URL: https://github.com/llvm/llvm-project/commit/b3569280586aec3e4d5ea61634f0a841e5827244
DIFF: https://github.com/llvm/llvm-project/commit/b3569280586aec3e4d5ea61634f0a841e5827244.diff
LOG: [libc++] Fix the check-format job
Previously, it wouldn't take into account files in ignore_format.txt
(at least not on OSX) because the `find` command would return file names
like `libcxx/src//new_handler.cpp`, which never matched the file names
in `ignore_format.txt`.
Differential Revision: https://reviews.llvm.org/D153416
Added:
Modified:
libcxx/utils/ci/run-buildbot
Removed:
################################################################################
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index cd8a7e35052aa..0dffe7e818c15 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -198,7 +198,7 @@ check-format)
${GIT_CLANG_FORMAT} \
--
diff \
--extensions ',h,hpp,c,cpp,cppm,inc,ipp' HEAD~1 \
- -- $(find libcxx/{benchmarks,include,modules,src}/ -type f | grep -vf libcxx/utils/data/ignore_format.txt) \
+ -- $(find libcxx/{benchmarks,include,modules,src} -type f | grep -vf libcxx/utils/data/ignore_format.txt) \
| tee ${BUILD_DIR}/clang-format.patch
# Check if the
diff is empty, fail otherwise.
! grep -q '^--- a' ${BUILD_DIR}/clang-format.patch
More information about the libcxx-commits
mailing list