[libcxx-commits] [PATCH] D153209: Revert "[libc++][PSTL] Add missing includes to PSTL headers"

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 21 13:01:11 PDT 2023


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I don't understand this patch. We follow include-what-you-use in libc++. These headers are using the entities declared by the includes you're removing, I think we should keep them. In other words, those files should have been including these headers since they were written, regardless of whether it helps with disentangling the Clang modules story or not. Do I misunderstand something? If not, I think we can abandon this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153209/new/

https://reviews.llvm.org/D153209



More information about the libcxx-commits mailing list