[libcxx-commits] [libcxx] 9ff36c2 - [libc++] Guard terminate_successful with TEST_HAS_NO_EXCEPTIONS

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2023-06-21T08:34:51-04:00
New Revision: 9ff36c24a04d9aae61ae09f460c3344f16bb40dc

URL: https://github.com/llvm/llvm-project/commit/9ff36c24a04d9aae61ae09f460c3344f16bb40dc
DIFF: https://github.com/llvm/llvm-project/commit/9ff36c24a04d9aae61ae09f460c3344f16bb40dc.diff

LOG: [libc++] Guard terminate_successful with TEST_HAS_NO_EXCEPTIONS

This one is a bit twisted. Some platforms don't have support for
exiting in a clean manner, so they don't provide std::exit(). As
a result, defining `terminate_successful()` on those platforms won't
work, and the PSTL tests that rely on `terminate_successful()` also
won't work.

However, we don't have a notion of "no clean termination" in libc++,
so we can't properly guard this. Since embedded platforms that don't
support clean termination usually also don't enable exceptions, we
don't need to be able to run those `terminate_successful` PSTL tests,
and guarding the definition of `terminate_successful` with
TEST_HAS_NO_EXCEPTIONS works pretty well.

This is kind of a hack for the lack of having a concept of "no clean
termination" in the library and in the test suite.

Differential Revision: https://reviews.llvm.org/D153302

Added: 
    

Modified: 
    libcxx/test/support/test_execution_policies.h

Removed: 
    


################################################################################
diff  --git a/libcxx/test/support/test_execution_policies.h b/libcxx/test/support/test_execution_policies.h
index d0cf0ddb6f0d5..df2ce94c7cc91 100644
--- a/libcxx/test/support/test_execution_policies.h
+++ b/libcxx/test/support/test_execution_policies.h
@@ -58,6 +58,8 @@ struct Bool {
   }
 };
 
+#ifndef TEST_HAS_NO_EXCEPTIONS
 [[noreturn]] inline void terminate_successful() { std::exit(0); }
+#endif
 
 #endif // TEST_SUPPORT_TEST_EXECUTION_POLICIES