[libcxx-commits] [PATCH] D150831: [libc++] Implement ranges::ends_with

[Zijun Zhao via Phabricator via libcxx-commits]

ZijunZhao added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/alg.ends_with/ranges.ends_with.pass.cpp:218
+constexpr bool test() {
+  types::for_each(types::forward_iterator_list<int*>{}, []<class I2>() {
+    types::for_each(types::forward_iterator_list<int*>{}, []<class I1>() {
----------------
var-const wrote:
> Shouldn't we also test with `input_iterator`s?
In line 252, `forward_iterator_list` is tested and include all `input_iterators`  features. So `input_iterators` are tested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150831/new/

https://reviews.llvm.org/D150831