[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

Tue Jun 20 16:21:03 PDT 2023

rprichard added a comment.

In D139147#4433086 <https://reviews.llvm.org/D139147#4433086>, @Mordante wrote:

> In D139147#4416112 <https://reviews.llvm.org/D139147#4416112>, @rprichard wrote:
>
>> In D139147#4414313 <https://reviews.llvm.org/D139147#4414313>, @Mordante wrote:
>>
>>> The patch is quite large. I think it would be better to land it in smaller parts, preferable after we see these changes have a green Android CI.
>>
>> Sure, I can split parts of it off. I think the XFAIL additions and the libcxx/lib/abi* files are a good place to start.
>
> The ABI could remain, but I would like to see the XFAIL annotations and the Dockerfile changes in two separate commits.

Yeah that makes sense.

FWIW, I'm experimenting with a different way of packaging the Android test components. Instead of testing using the Android NDK, maybe we could use an ordinary upstream LLVM with an Android sysroot. The sysroot is much smaller (e.g. a few hundred MB IIRC), so I think we could add it to ldionne/libcxx-builders. Maybe we could then have a completely independent Docker image that contains the emulator and Android OS image. It might even be possible to reuse the existing Linux builders, but with KVM turned on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147