[libcxx-commits] [PATCH] D152469: [libc++] Diagnose bad iterators in the classic algorithms

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D152469#4435488 <https://reviews.llvm.org/D152469#4435488>, @eaeltsin wrote:

> Okay, we have a significant amount of failures from this, will likely require 2-3 weeks of cleanups.

Interesting, thanks for the feedback. My builds are still running, I had to restart them after some stupid mistake I made.

Do you feel like it would be helpful to introduce this behind a macro? We could make it opt-in for one release, and then make it opt-out for one release, and then make it mandatory (or something along those lines). I feel like anything that takes 2-3 weeks of cleanups is significant enough that it should allow being done gradually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152469/new/

https://reviews.llvm.org/D152469