[libcxx-commits] [PATCH] D153285: [NFC][libc++] Addresses LWG3905.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

In D153285#4432970 <https://reviews.llvm.org/D153285#4432970>, @philnik wrote:

> This looks more like a "Nothing to do" to me, since we don't actually have to change anything.

To me "Nothing to do" means no library implementation needs to make changes, not just us.
Otherwise when we don't implement a feature and it's removed from the Standard that would mean nothing to do too.



================
Comment at: libcxx/docs/Status/Cxx2cIssues.csv:1
 "Issue #","Issue Name","Meeting","Status","First released version","Labels"
 "`2994 <https://wg21.link/LWG2994>`__","Needless UB for ``basic_string`` and ``basic_string_view``","Varna June 2023","","",""
----------------
ldionne wrote:
> `libcxx/test/std/depr/depr.c.headers/fenv_h.compile.pass.cpp:60` has
> 
> ```
> fexcept_t fex = 0;
> ```
> 
> which is not conforming IIUC. We should change it.
Nice catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153285/new/

https://reviews.llvm.org/D153285