[libcxx-commits] [PATCH] D153272: [libc++] Get rid of _LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jun 20 07:30:59 PDT 2023
ldionne added inline comments.
================
Comment at: libcxx/src/new.cpp:13
-#if !defined(__GLIBCXX__) && \
- !defined(_LIBCPP_ABI_VCRUNTIME) && \
- !defined(_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS)
+#if !defined(__GLIBCXX__) && !defined(_LIBCPP_ABI_VCRUNTIME)
----------------
philnik wrote:
> Do you plan to move these conditions into CMake? It seems kind-of weird to just ignore `LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS` in some cases.
Ideally, I think those should be defined via the CMake cache instead, yeah. Since they also influence what we do for exceptions, I'd like to tackle those independently.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153272/new/
https://reviews.llvm.org/D153272
More information about the libcxx-commits
mailing list