[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D139147#4416112 <https://reviews.llvm.org/D139147#4416112>, @rprichard wrote:

> In D139147#4414313 <https://reviews.llvm.org/D139147#4414313>, @Mordante wrote:
>
>> The patch is quite large. I think it would be better to land it in smaller parts, preferable after we see these changes have a green Android CI.
>
> Sure, I can split parts of it off. I think the XFAIL additions and the libcxx/lib/abi* files are a good place to start.

The ABI could remain, but I would like to see the XFAIL annotations and the Dockerfile changes in two separate commits.

>> It would be great if you can have a buildbot running in CGE so we can see the patch passes the CI. Could you reach out to @ldionne to get a buildkite token and talk to him about how we want to maintain the Android Docker images. I think it would make sense that you should be able to maintain them.
>
> ldionne gave me a buildkite token a while ago, and I set up a test server last night, so this patch did pass CI: https://buildkite.com/llvm-project/libcxx-ci/builds/26029

nice thanks! This makes is a lot easier to verify the patch works :-)

> I see that libcxx only supports the last two stable releases of Clang (15 and 16), but the latest NDK is r25c, which is between Clang 13 and 14. NDK r26 should be released sometime this year with a compiler newer than Clang 16.

How often are Android NDKs released? I would like to know how often we Android uses compilers we no longer officially support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147