[libcxx-commits] [PATCH] D153211: [libc++][Modules] Make module exports consistent with header includes

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__format/format_context.h:24
 #include <__iterator/concepts.h>
+#include <__locale>
 #include <__memory/addressof.h>
----------------
I doubt this is needed, this is part of `<locale>` and should be exported by `<locale>`. When this is really needed it should be moved to line 31 in the `_LIBCPP_HAS_NO_LOCALIZATION`. Otherwise the CI will fail.


================
Comment at: libcxx/include/cwchar:113
 #include <cwctype>
+#include <stdio.h>
 
----------------
Is this really needed, it looks weird; C headers should be independent.


================
Comment at: libcxx/include/mdspan:64-65
 #include <__mdspan/extents.h>
+#include <array>
+#include <span>
 
----------------
Can you move these to the `__mdspan/extents.h` where the are really needed?


================
Comment at: libcxx/include/string_view:230
 #include <__type_traits/type_identity.h>
+#include <initializer_list>
 #include <iosfwd>
----------------
The header does not use `initializer_list` why is it needed?


================
Comment at: libcxx/utils/libcxx/test/header_information.py:76
+    "__config",
+    "__iterator/readable_traits.h",
+))
----------------
I really like to see comment why this file is in this list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153211/new/

https://reviews.llvm.org/D153211