[libcxx-commits] [PATCH] D153212: [libc++][Modules] Remove explicit exports from modules that `export *`

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jun 17 18:55:54 PDT 2023


iana created this revision.
iana added reviewers: ldionne, Mordante, philnik, Bigcheese.
Herald added a subscriber: ributzka.
Herald added a project: All.
iana requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This may be a clang bug, but explicit exports interfere with `export *`, especially in local submodule visibility mode. For example, exporting `depr.stdint_h` from `cstdint` causes std::int32_t to become an "unresolved using declaration" in LSV if `cstdint` and `stdint.h` are promoted to top level modules. This was previously worked around by exporting `Darwin.C.stdint` in `depr.stdint_h`, but that only works on Apple platforms, and it stops working when `cstdint` and `stdint.h` are promoted to top level modules.

Remove all of the explicit `export` statements in modules that have `export *`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153212

Files:
  libcxx/include/module.modulemap.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153212.532439.patch
Type: text/x-patch
Size: 5831 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230618/c4ac96ea/attachment.bin>


More information about the libcxx-commits mailing list