[libcxx-commits] [PATCH] D153209: Revert "[libc++][PSTL] Add missing includes to PSTL headers"

[Ian Anderson via Phabricator via libcxx-commits]

iana created this revision.
iana added reviewers: ldionne, Mordante, philnik, Bigcheese.
Herald added subscribers: ributzka, miyuki.
Herald added a project: All.
iana requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

It doesn't help modules to add extra includes for things that are already transitively included. What's needed is additional module exports.

This reverts commit 5ac0c1af8215ae5b084235c34be60a50dbe4e92e <https://reviews.llvm.org/rG5ac0c1af8215ae5b084235c34be60a50dbe4e92e>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153209

Files:
  libcxx/include/__algorithm/pstl_find.h
  libcxx/include/__pstl/internal/execution_impl.h
  libcxx/include/__pstl/internal/parallel_backend_serial.h
  libcxx/include/__pstl/internal/unseq_backend_simd.h


Index: libcxx/include/__pstl/internal/unseq_backend_simd.h
===================================================================
--- libcxx/include/__pstl/internal/unseq_backend_simd.h
+++ libcxx/include/__pstl/internal/unseq_backend_simd.h
@@ -12,15 +12,12 @@
 
 #include <__config>
 #include <__functional/operations.h>
-#include <__iterator/iterator_traits.h>
 #include <__type_traits/is_arithmetic.h>
-#include <__type_traits/is_same.h>
-#include <__utility/move.h>
 #include <__utility/pair.h>
 #include <cstddef>
 #include <cstdint>
 
-#include <__pstl/internal/utils.h>
+#include "utils.h"
 
 // This header defines the minimum set of vector routines required
 // to support parallel STL.
Index: libcxx/include/__pstl/internal/parallel_backend_serial.h
===================================================================
--- libcxx/include/__pstl/internal/parallel_backend_serial.h
+++ libcxx/include/__pstl/internal/parallel_backend_serial.h
@@ -14,7 +14,6 @@
 #include <__memory/allocator.h>
 #include <__pstl/internal/execution_impl.h>
 #include <__utility/forward.h>
-#include <cstddef>
 
 #if !defined(_LIBCPP_HAS_NO_INCOMPLETE_PSTL) && _LIBCPP_STD_VER >= 17
 
Index: libcxx/include/__pstl/internal/execution_impl.h
===================================================================
--- libcxx/include/__pstl/internal/execution_impl.h
+++ libcxx/include/__pstl/internal/execution_impl.h
@@ -14,11 +14,9 @@
 #include <__iterator/iterator_traits.h>
 #include <__type_traits/conditional.h>
 #include <__type_traits/conjunction.h>
-#include <__type_traits/decay.h>
-#include <__type_traits/integral_constant.h>
 #include <__type_traits/is_base_of.h>
 
-#include <__pstl/internal/execution_defs.h>
+#include "execution_defs.h"
 
 #if !defined(_LIBCPP_HAS_NO_INCOMPLETE_PSTL) && _LIBCPP_STD_VER >= 17
 
Index: libcxx/include/__algorithm/pstl_find.h
===================================================================
--- libcxx/include/__algorithm/pstl_find.h
+++ libcxx/include/__algorithm/pstl_find.h
@@ -15,7 +15,6 @@
 #include <__algorithm/pstl_frontend_dispatch.h>
 #include <__config>
 #include <__iterator/cpp17_iterator_concepts.h>
-#include <__iterator/iterator_traits.h>
 #include <__type_traits/is_execution_policy.h>
 #include <__type_traits/remove_cvref.h>
 #include <__utility/terminate_on_exception.h>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153209.532436.patch
Type: text/x-patch
Size: 2322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230618/1e22c6b5/attachment.bin>