[libcxx-commits] [PATCH] D153140: [libc++][NFC] Apply clang-format on large parts of the code base

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__type_traits/invoke.h:355
 
-  using type = __conditional_t<
-      _IsNotSame<_Result, __nat>::value,
-      __conditional_t<is_void<_Ret>::value, true_type, __is_core_convertible<_Result, _Ret> >,
-      false_type>;
+  using type              = __conditional_t< _IsNotSame<_Result, __nat>::value,
+                                __conditional_t<is_void<_Ret>::value, true_type, __is_core_convertible<_Result, _Ret> >,
----------------
ldionne wrote:
> Mordante wrote:
> > Good old C++03 ;-)
> Yeah, that's annoying! Is this a request to change this instance and other ones? I'm not sure it's possible because clang-format will try to enforce that (unfortunate) whitespace.
Fixing it will refrain clang-format from touching it. Feel free to ignore it. 


================
Comment at: libcxx/include/__type_traits/is_scalar.h:21
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
-#  pragma GCC system_header
+#pragma GCC system_header
 #endif
----------------
ldionne wrote:
> Mordante wrote:
> > Odd it changed it here, but I don't see issues with the change.
> I played around a bit and it looks like clang-format thinks that this file is objective-C because of the block syntax, and our `.clang-format` file doesn't apply to Objc. I'd like to address that in a separate patch.
A cool you found a cause. I was quite baffled by it. I initially was concerned there was an issue with the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153140/new/

https://reviews.llvm.org/D153140