[libcxx-commits] [PATCH] D151493: [libcxx] Handle windows system error code mapping in std::error_code.

[James Y Knight via Phabricator via libcxx-commits]

jyknight added a comment.

In D151493#4425486 <https://reviews.llvm.org/D151493#4425486>, @philnik wrote:

> For example, moving `__win_err_to_errc` is NFC AFAICT.

In the new code, `__win_err_to_errc` is a private implementation detail of `std::system_error`, living in an anonymous namespace inside `system_error.cpp`. In the old code, it's an extern function used by `directory_iterator.cpp` and `operations.cpp` within `std::filesystem::detail`. I _could_ kludge together a separate change which moves the source location of the code into `system_error.cpp`, while still having it be an extern symbol in the `std::filesystem::detail` namespace, but ISTM that's really stretching the bounds of a reasonable sort of NFC change to split off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151493/new/

https://reviews.llvm.org/D151493