[libcxx-commits] [PATCH] D153140: [libc++][NFC] Apply clang-format on large parts of the code base

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 16 10:41:40 PDT 2023


Mordante accepted this revision.
Mordante added a comment.

In D153140#4428753 <https://reviews.llvm.org/D153140#4428753>, @ldionne wrote:

> @Mordante I will expand the scope of this patch to touch more headers. I won't do everything because I want to avoid touching active areas and manually auditing everything is time consuming, but I've got a patch that applies clang-format to a couple hundred files.

Thanks! I looked over the files and didn't spot bad formatting.



================
Comment at: libcxx/include/__type_traits/invoke.h:355
 
-  using type = __conditional_t<
-      _IsNotSame<_Result, __nat>::value,
-      __conditional_t<is_void<_Ret>::value, true_type, __is_core_convertible<_Result, _Ret> >,
-      false_type>;
+  using type              = __conditional_t< _IsNotSame<_Result, __nat>::value,
+                                __conditional_t<is_void<_Ret>::value, true_type, __is_core_convertible<_Result, _Ret> >,
----------------
Good old C++03 ;-)


================
Comment at: libcxx/include/__type_traits/is_scalar.h:21
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
-#  pragma GCC system_header
+#pragma GCC system_header
 #endif
----------------
Odd it changed it here, but I don't see issues with the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153140/new/

https://reviews.llvm.org/D153140



More information about the libcxx-commits mailing list