[libcxx-commits] [PATCH] D153136: [libc++] Move non operator new definitions outside of new.cpp

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, but I have some remarks.



================
Comment at: libcxx/src/new.cpp:10
 #include <__memory/aligned_alloc.h>
 #include <cstdlib>
 #include <new>
----------------
Is this include still needed?


================
Comment at: libcxx/src/new_helpers.cpp:24
+#  else
+  _VSTD::abort();
+#  endif
----------------
yronglin wrote:
> Nit: Should we use std:: in new code?
We should, but this is moved. (I still like to fix it)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153136/new/

https://reviews.llvm.org/D153136