[libcxx-commits] [PATCH] D153140: [libc++][NFC] Reformat all the benchmarks

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

LGTM! After committing can you do a follow-up commit, adding this commit to `.git-blame-ignore-revs`?

I noticed in the past we have quite some headers in `include` that are "almost-formatted" (diff < 25-ish lines) would it make sense to do these too?

In general I wonder whether we should be slightly more aggressive in removing this tech debt. I know we want to avoid disrupting active patches, which I think is great. OTOH we have quite some inactive places were we could do
`_VSTD` -> `std`
`typedef` -> `using`
`_LIBCPP_INLINE_VISIBILITY` -> `_LIBCPP_HIDE_FROM_ABI`

This is something we need to point out in reviews quite often or get questions about it.

We still have a lot of old patches, but I think we need quite some effort to rebase them anyway; and I'm not even sure whether to original authors are intending to pursue these patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153140/new/

https://reviews.llvm.org/D153140