[libcxx-commits] [PATCH] D152168: [libc++] Roll up fstream support into filesystem support

[Peter Smith via Phabricator via libcxx-commits]

peter.smith added a comment.

In D152168#4427603 <https://reviews.llvm.org/D152168#4427603>, @michaelplatings wrote:

> LLVM Embedded Toolchain for Arm <https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm> also supports `<fstream>` but not `<filesystem>`. We have a C library so supporting `<fstream>` is easy. We don't have POSIX support so supporting `<filesystem>` is much more challenging.
>
> Please can this change be reverted?

To give some background. Simple file IO can be handled by an embedded toolchain using semihosting IO https://github.com/ARM-software/abi-aa/blob/main/semihosting/semihosting.rst (also supported by RISCV https://github.com/riscv-software-src/riscv-semihosting) the POSIX function in posix_compat.h can't easily be supported using that API.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152168/new/

https://reviews.llvm.org/D152168