[libcxx-commits] [PATCH] D152939: [libc++] Add tests to make sure that stable algorithms work without memory available

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 15 09:46:29 PDT 2023


ldionne accepted this revision.
ldionne added a subscriber: power-llvm-team.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but please don't forget to undo the temporary changes.

@power-llvm-team Could someone please have a look at the failures on AIX? We suspect those are related to how the linker handles weak defs being overridden in a user program. I ran into similar issues here: https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new.size_align_nothrow.replace.indirect.pass.cpp#L16



================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:34
-  #
-  # Light pre-commit tests for things like formatting or when people forget
-  # to update generated files.
----------------
You need to get rid of this diff before shipping!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152939/new/

https://reviews.llvm.org/D152939



More information about the libcxx-commits mailing list