[libcxx-commits] [PATCH] D151814: [libc++][modules] Adds the C++23 std module.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/modules/std/string.cppm:74
 
+  // TODO MODULES is this a bug?
+#if 1
----------------
Mordante wrote:
> Except for this change all other changes in this directory should be in a separate commit. For now I keep them here. @H-G-Hristov is making great progress on P1614 (the spaceship paper). This means a lot of changes to the to the modules. After this patch is accepted I will coordinate with @H-G-Hristov regarding splitting this patch and avoid conflicts with the spaceship patches.
I checked there are no open operator!= patches.


================
Comment at: libcxx/test/libcxx/modules_include.gen.py:17
 sys.path.append(sys.argv[1])
 from libcxx.test.header_information import lit_header_restrictions, public_headers
 
----------------
ldionne wrote:
> We should clean up the naming of these files in a separate patch to make it clear what's testing C++20 modules and what's testing Clang modules.
Good point. I'll make a followup patch for the renaming after landing this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151814/new/

https://reviews.llvm.org/D151814