[libcxx-commits] [libcxxabi] a86df48 - [libc++abi] Avoid including source files into unittest_demangle

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2023-06-15T11:45:05-04:00
New Revision: a86df48c38e8138ad67050967cef63548bffb230

URL: https://github.com/llvm/llvm-project/commit/a86df48c38e8138ad67050967cef63548bffb230
DIFF: https://github.com/llvm/llvm-project/commit/a86df48c38e8138ad67050967cef63548bffb230.diff

LOG: [libc++abi] Avoid including source files into unittest_demangle

That is not necessary to test what we're testing, and in fact including
abort_message.cpp into that file caused some link errors if we didn't
link some of the dependencies of libc++abi directly into the test.

Differential Revision: https://reviews.llvm.org/D152862

Added: 
    

Modified: 
    libcxxabi/test/unittest_demangle.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxxabi/test/unittest_demangle.pass.cpp b/libcxxabi/test/unittest_demangle.pass.cpp
index 07aced2ec1159..3f86e9c49a8a5 100644
--- a/libcxxabi/test/unittest_demangle.pass.cpp
+++ b/libcxxabi/test/unittest_demangle.pass.cpp
@@ -7,15 +7,16 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03
+// ADDITIONAL_COMPILE_FLAGS: -Wno-unused-function
 
-#include "../src/cxa_demangle.cpp"
-#include "../src/abort_message.cpp"
+#include <cassert>
+#include <utility>
 
-using namespace __cxxabiv1;
+#include "../src/demangle/ItaniumDemangle.h"
 
 void testPODSmallVector() {
   { // {push/pop}_back
-    PODSmallVector<int, 1> PSV;
+    itanium_demangle::PODSmallVector<int, 1> PSV;
     PSV.push_back(0);
     PSV.push_back(1);
     PSV.push_back(2);
@@ -33,12 +34,12 @@ void testPODSmallVector() {
   }
 
   {
-    PODSmallVector<int, 1> PSV1;
+    itanium_demangle::PODSmallVector<int, 1> PSV1;
     PSV1.push_back(1);
     PSV1.push_back(2);
     PSV1.push_back(3);
 
-    PODSmallVector<int, 1> PSV2;
+    itanium_demangle::PODSmallVector<int, 1> PSV2;
     std::swap(PSV1, PSV2);
     assert(PSV1.size() == 0);
     assert(PSV2.size() == 3);
@@ -60,8 +61,8 @@ void testPODSmallVector() {
   }
 
   {
-    PODSmallVector<int, 10> PSV1;
-    PODSmallVector<int, 10> PSV2;
+    itanium_demangle::PODSmallVector<int, 10> PSV1;
+    itanium_demangle::PODSmallVector<int, 10> PSV2;
     PSV1.push_back(0);
     PSV1.push_back(1);
     PSV1.push_back(2);