[libcxx-commits] [PATCH] D152971: [libc++] Don't automatically define LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS with libcxxrt

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 15 08:23:52 PDT 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rGfa90e2b988de: [libc++] Don't automatically define LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS with… (authored by ldionne).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152971/new/

https://reviews.llvm.org/D152971

Files:
  libcxx/cmake/Modules/HandleLibCXXABI.cmake


Index: libcxx/cmake/Modules/HandleLibCXXABI.cmake
===================================================================
--- libcxx/cmake/Modules/HandleLibCXXABI.cmake
+++ libcxx/cmake/Modules/HandleLibCXXABI.cmake
@@ -143,10 +143,6 @@
 
 # Link against a system-provided libcxxrt
 elseif ("${LIBCXX_CXX_ABI}" STREQUAL "libcxxrt")
-  # libcxxrt does not provide aligned new and delete operators
-  # TODO: We're keeping this for backwards compatibility, but this doesn't belong here.
-  set(LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS ON)
-
   if(NOT LIBCXX_CXX_ABI_INCLUDE_PATHS)
     message(STATUS "LIBCXX_CXX_ABI_INCLUDE_PATHS not set, using /usr/include/c++/v1")
     set(LIBCXX_CXX_ABI_INCLUDE_PATHS "/usr/include/c++/v1")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152971.531768.patch
Type: text/x-patch
Size: 719 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230615/ab94eb64/attachment.bin>


More information about the libcxx-commits mailing list