[libcxx-commits] [PATCH] D152652: [libc++] Merge _LIBCPP_FUNC_VIS, _LIBCPP_TYPE_VIS and _LIBCPP_EXCEPTION_ABI into _LIBCPP_EXPORTED_FROM_ABI

Shoaib Meenai via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 14 10:34:35 PDT 2023


smeenai added a comment.

Yeah, I feel like there might have been some reason for the separate macros, but I can't remember anymore, and a git search didn't find anything relevant. Consolidating them makes sense to me.

How come you're not removing the `_LIBCPP_EXCEPTION_ABI` definition in `__config` as well?

https://github.com/llvm/llvm-project/blob/main/libcxx/docs/DesignDocs/VisibilityMacros.rst should be updated as part of this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152652/new/

https://reviews.llvm.org/D152652



More information about the libcxx-commits mailing list