[libcxx-commits] [PATCH] D146815: [ASan][libc++] Annotating std::deque with all allocators

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 14 09:27:04 PDT 2023


philnik added inline comments.


================
Comment at: libcxx/include/deque:980
         const void* __new_con_end) const {
-        if (__beg && is_same<allocator_type, __default_allocator_type>::value)
+        if (__beg != nullptr && __asan_annotate_container_with_allocator<_Allocator>::value)
             __sanitizer_annotate_double_ended_contiguous_container(
----------------
This needs tests to make sure that custom allocators work and that customizing `__asan_annotate_container_with_allocator` can be customized to disable annotations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146815/new/

https://reviews.llvm.org/D146815



More information about the libcxx-commits mailing list