[libcxx-commits] [PATCH] D152775: [libc++][spaceship][NFC] P1614R2: Status page - mark header synopsis sections as "Complete"

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D152775#4416463 <https://reviews.llvm.org/D152775#4416463>, @H-G-Hristov wrote:

> @Mordante 
> There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".

Nothing to do, means there is no (hypothetical) change needed in the library. For example when I implement the TZDB parts of the library I will directly use the operators as defined in P1614 <https://reviews.llvm.org/P1614>, not what's in the TZDB paper. Had we implemented the TZDB change first we would have needed make changes, like we did for the calendar changes. So then it's not Nothing to do.

Some papers update the wording of the Standard to a new style, without changing the meaning for the wording. These changes are nothing to do. I hope that makes it clearer for you.

For these changes in the status table I probably wouldn't have listed the synopsis at all. This page is temporary and used for the libc++ developers to track the status. It will be removed in the future. So I don't feel to strong about Complete/Nothing to do here; I feel Complete is slightly better.

LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152775/new/

https://reviews.llvm.org/D152775