[libcxx-commits] [PATCH] D148693: [libc++] Set correct size at the end of growing std::string

Tacet via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 13 18:14:44 PDT 2023


AdvenamTacet updated this revision to Diff 531132.
AdvenamTacet marked 2 inline comments as done.
AdvenamTacet added a comment.

As suggested, this update:

- reverts changes in `libcxx/include/__string/extern_template_lists.h`,
- in a comment, describes the bug and explains why the function is preserved,
- adds `_LIBCPP_HIDE_FROM_ABI` to `__grow_by_without_replace` (),
- removes changes in `libcxx/lib/abi`.

I hope, the patch may land after that change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148693/new/

https://reviews.llvm.org/D148693

Files:
  libcxx/include/string

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148693.531132.patch
Type: text/x-patch
Size: 6992 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230614/56828233/attachment.bin>


More information about the libcxx-commits mailing list