[libcxx-commits] [PATCH] D152469: [libc++] Diagnose bad iterators in the classic algorithms

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 13 15:59:46 PDT 2023


ldionne added subscribers: rupprecht, EricWF, libc++ vendors, ldionne.
ldionne added a comment.

I think we definitely want to do this because it could catch genuine bugs and also hardens us against Hyrum's law. The big challenge here is rolling this out without it being too painful. First things first. I'll run this on a significant code base to get an idea of how many failures we get.

@rupprecht or @EricWF  Could you also take this for a spin at Google once the CI is green? @philnik Please ping us here once this is ready to be taken for a spin.

Adding vendors for awareness.



================
Comment at: libcxx/include/__algorithm/transform.h:1
 //===----------------------------------------------------------------------===//
 //
----------------
We're missing a release note.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152469/new/

https://reviews.llvm.org/D152469



More information about the libcxx-commits mailing list