[libcxx-commits] [PATCH] D152862: [libc++abi] Avoid including source files into unittest_demangle

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added a reviewer: nickdesaulniers.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++abi.

That is not necessary to test what we're testing, and in fact including
abort_message.cpp into that file caused some link errors if we didn't
link some of the dependencies of libc++abi directly into the test.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152862

Files:
  libcxxabi/test/unittest_demangle.pass.cpp


Index: libcxxabi/test/unittest_demangle.pass.cpp
===================================================================
--- libcxxabi/test/unittest_demangle.pass.cpp
+++ libcxxabi/test/unittest_demangle.pass.cpp
@@ -7,15 +7,16 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03
+// ADDITIONAL_COMPILE_FLAGS: -Wno-unused-function
 
-#include "../src/cxa_demangle.cpp"
-#include "../src/abort_message.cpp"
+#include <cassert>
+#include <utility>
 
-using namespace __cxxabiv1;
+#include "../src/demangle/ItaniumDemangle.h"
 
 void testPODSmallVector() {
   { // {push/pop}_back
-    PODSmallVector<int, 1> PSV;
+    itanium_demangle::PODSmallVector<int, 1> PSV;
     PSV.push_back(0);
     PSV.push_back(1);
     PSV.push_back(2);
@@ -33,12 +34,12 @@
   }
 
   {
-    PODSmallVector<int, 1> PSV1;
+    itanium_demangle::PODSmallVector<int, 1> PSV1;
     PSV1.push_back(1);
     PSV1.push_back(2);
     PSV1.push_back(3);
 
-    PODSmallVector<int, 1> PSV2;
+    itanium_demangle::PODSmallVector<int, 1> PSV2;
     std::swap(PSV1, PSV2);
     assert(PSV1.size() == 0);
     assert(PSV2.size() == 3);
@@ -60,8 +61,8 @@
   }
 
   {
-    PODSmallVector<int, 10> PSV1;
-    PODSmallVector<int, 10> PSV2;
+    itanium_demangle::PODSmallVector<int, 10> PSV1;
+    itanium_demangle::PODSmallVector<int, 10> PSV2;
     PSV1.push_back(0);
     PSV1.push_back(1);
     PSV1.push_back(2);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152862.531081.patch
Type: text/x-patch
Size: 1431 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230613/7a470927/attachment.bin>