[libcxx-commits] [PATCH] D152736: [libc++] Mark slow tests as unsupported on GCC

Tue Jun 13 10:15:00 PDT 2023

ldionne marked an inline comment as done.
ldionne added a comment.

In D152736#4414860 <https://reviews.llvm.org/D152736#4414860>, @Mordante wrote:

> Once the CI finishes, can you update the difference in runtime for our CI.
> I know the format part does nothing, but the ranges part would be interesting to know.
>
> I will look at discourse later. Still I'm happy with the patch, since it offers a better message for format/chrono.
>
> LGTM! Since @philnik wrote on Discourse I leave the final approval to him.

I just checked and with this patch applied, the GCC run took ~15 minutes as opposed to ~24 minutes lately.

================
Comment at: libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cpp:11
-// TODO FMT Fix this test using GCC, it currently times out.
-// UNSUPPORTED: gcc-12

----------------
Mordante wrote:
> Am I right to assume you changed all these cases in format/chrono? If that is the case I will abandon D135787.
I think I caught everything, yes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152736/new/

https://reviews.llvm.org/D152736