[libcxx-commits] [PATCH] D152652: [libc++] Merge _LIBCPP_FUNC_VIS, _LIBCPP_TYPE_VIS and _LIBCPP_EXCEPTION_ABI into _LIBCPP_EXPORTED_FROM_ABI

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This makes sense to me, however we also probably want to take a look at the other `_VIS` macros and see if we can remove them in favor of `_LIBCPP_EXPORTED_FROM_ABI` or variants of it (e.g. applying type_visibility(default) at the namespace scope to get rid of `_LIBCPP_ENUM_VIS`).

Heads up @smeenai, does this make sense to you?



================
Comment at: libcxx/include/__algorithm/shuffle.h:24
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
 #  pragma GCC system_header
 #endif
----------------
Commit message typo: identially


================
Comment at: libcxx/include/__algorithm/shuffle.h:25
 #  pragma GCC system_header
 #endif
 
----------------
Missing `.clang-format` updates and `VisibilityMacros.rst` changes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152652/new/

https://reviews.llvm.org/D152652