[libcxx-commits] [PATCH] D152581: [libc++][PSTL] Implement std::generate{, _n}

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/CMakeLists.txt:85
   __algorithm/pstl_backends/cpu_backends/thread.h
   __algorithm/pstl_backends/cpu_backends/transform.h
   __algorithm/pstl_backends/cpu_backends/transform_reduce.h
----------------
Don't forget to update the paper list.


================
Comment at: libcxx/include/__algorithm/pstl_generate.h:1
+//===----------------------------------------------------------------------===//
+//
----------------
Missing updates to the customization point list.


================
Comment at: libcxx/include/algorithm:1809
 #include <__algorithm/pstl_for_each.h>
+#include <__algorithm/pstl_generate.h>
 #include <__algorithm/pstl_merge.h>
----------------
Missing synopsis update. Did we forget to update it for the past several patches? I get a feeling that we did.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152581/new/

https://reviews.llvm.org/D152581