[libcxx-commits] [PATCH] D152736: [libc++] Mark slow tests as unsupported on GCC

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 12 11:51:17 PDT 2023


Mordante added subscribers: philnik, Mordante.
Mordante accepted this revision as: Mordante.
Mordante added a comment.

Once the CI finishes, can you update the difference in runtime for our CI.
I know the format part does nothing, but the ranges part would be interesting to know.

I will look at discourse later. Still I'm happy with the patch, since it offers a better message for format/chrono.

LGTM! Since @philnik wrote on Discourse I leave the final approval to him.



================
Comment at: libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cpp:11
-// TODO FMT Fix this test using GCC, it currently times out.
-// UNSUPPORTED: gcc-12
 
----------------
Am I right to assume you changed all these cases in format/chrono? If that is the case I will abandon D135787.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152736/new/

https://reviews.llvm.org/D152736



More information about the libcxx-commits mailing list