[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

The patch is quite large. I think it would be better to land it in smaller parts, preferable after we see these changes have a green Android CI.

It would be great if you can have a buildbot running in CGE so we can see the patch passes the CI. Could you reach out to @ldionne to get a buildkite token and talk to him about how we want to maintain the Android Docker images. I think it would make sense that you should be able to maintain them.

As mentioned in the review, please move the Docker changes for the Linux CI in a new patch.



================
Comment at: libcxx/utils/ci/Dockerfile:29
 #
+#   $ docker build -t ldionne/libcxx-builder-base libcxx/utils/ci -f libcxx/utils/ci/Dockerfile.base
 #   $ docker build -t ldionne/libcxx-builder libcxx/utils/ci
----------------
Can you make a separate review of this file and the new `Dockerfile.base`. I really would like to test and land these separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147