[libcxx-commits] [PATCH] D139497: [libc++][Android] Adjust FP conversion tests for Bionic

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Can you rebase this patch so we can see the CI run. (Mainly to make sure it doesn't break things unexpectedly.)



================
Comment at: libcxx/test/std/strings/string.conversions/stold.pass.cpp:48
     }
+#endif
 
----------------



================
Comment at: libcxx/test/std/strings/string.conversions/stold.pass.cpp:115
     }
+#endif
 #ifndef TEST_HAS_NO_EXCEPTIONS
----------------



================
Comment at: libcxx/utils/libcxx/test/features.py:169
+              // Never enable the workaround on Android M or newer.
+              if (android_get_device_api_level() >= 23) return 0;
+              char buf[100];
----------------



================
Comment at: libcxx/utils/libcxx/test/features.py:175
+          """),
+          actions=[AddCompileFlag('-DANDROID_PRINTF_NAN_NO_SIGN')]),
+
----------------
This is the prefix we use in our test suite.


================
Comment at: libcxx/utils/libcxx/test/features.py:188
+              // unaffected architectures.
+            #if defined(__LP64__)
+              if (android_get_device_api_level() >= 26) return 0;
----------------
How about testing this macro at line 181 insted?


================
Comment at: libcxx/utils/libcxx/test/features.py:189
+            #if defined(__LP64__)
+              if (android_get_device_api_level() >= 26) return 0;
+              long double result = strtold("NAN", NULL);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139497/new/

https://reviews.llvm.org/D139497