[libcxx-commits] [PATCH] D152381: [libc++] Extract ErrorHandler and related utilities from filesystem_common

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for the cleanup! LGMT, but one request.



================
Comment at: libcxx/src/filesystem/error.h:17
+#include <cstdint>
+#include <filesystem>
+#include <string>
----------------
Would it be possible to move the Windows specific code to a separate header, for example `windows_error.h`. I've used `make_windows_error` in `<print>`, where the CI fails if filesystem is disabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152381/new/

https://reviews.llvm.org/D152381